coreboot-nitrokey: hard-code ME state during boot #1596
Conversation
Signed-off-by: Markus Meissner <[email protected]>
|
The originating issue describes what has been tested, 1. to 4. and all are either empty or disabled. Namely verified on NV41 & NS50 |
|
We'll run another test-iteration also for the patch against upstream and plan to officially release tomorrow. |
@daringer ME linux modules are not packed under Heads for a while, I have opened an issue to remove artifacts and not build them forward from linux configurations at #1597 (comment) since no current board configurations actually instruct modules/linux to pack them under modules.cpio. Therefore, you only have cbmem output under Heads, no dmesg output from kernel in regard of ME. |
|
oh sorry, for clarification: We did inspections of |
fixes Nitrokey#39
Dasharo v1.7.2 introduced a feature to always set the ME state during boot based on the EDK2 defined values.
This led to the ME being activated in Nitrokey's v2.4 release, this PR fixes this by hard-coding the EDK2 defined values.
This PR is intentionally minimal to minimize testing and release fast - the Nitropad releases, will be build from this branch.
We are currently testing - it affects anyways the
coreboot-nitrokeymodule exclusively - so don't see further needs for testing - we will not only test our branch, but also the upstream artifacts. Once the tests are done I will promote this PR to "ready-for-review".