Bump Dasharo Coreboot / hotp-verification; fix nitropad-nxx ec-powerdown #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove all previous coreboot patches (as they are already included) * to be investigated: linux trampoline patch * add new patch to hardcode sleep configuration * activate smmstore as dasharo vendor code requires it Signed-off-by: Markus Meissner <[email protected]>
Signed-off-by: Markus Meissner <[email protected]>
* overwriting a hotp secret is not possible anymore * make sure to delete the hotp secret before setting a new one * requires one additional user presence check during HOTP setup * bump to v1.5 Signed-off-by: Markus Meissner <[email protected]>
|
@JonathonHall-Purism time to test hotp for regression and approve? |
|
Tested without regression
|
tlaurion
requested changes
Dec 29, 2023
|
At this point we cannot get rid of the |
|
We also did another full test iteration today, fully confirmed what is written in "Test Results" in the initial post |
49 tasks
JonathonHall-Purism
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Tested Librem 14 + Librem Key, looks good to me. Thanks @daringer
tlaurion
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the upstream relevant part of Nitrokey's next release for the Nitropads, it consists of three parts:
nitropad-nxxhotp-verificationto obey Nitrokey 3's extended security modelhotp-verificationversions + NK3 v1.6 will not allow overwriting the HOTP secret, workaround: delete it manually usingnitropyhotp-verificationversion the HOTP secret is first removed before setting it again during HOTP regenerationTest Results
First round of tests was done for
t430-hotp-max,nitropad-nv41,nitropad-ns50:.zipllvm-pipe, works with QubesOS 4.2site-local)We plan for another round of testing early in January, once these tests confirm the listed ones - I'll change the PR to be ready-for-review.