feat: start 라운드 추가 관련 작업들 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying moyeomoyeo with
|
| Latest commit: |
0a0cb09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1302c5dd.moyeomoyeo.pages.dev |
| Branch Preview URL: | https://feat-0705-about-start.moyeomoyeo.pages.dev |
haryung-lee
approved these changes
Jul 5, 2024
| request: { | ||
| teamBuildingUuid: string; | ||
| }; | ||
| response: unknown; |
There was a problem hiding this comment.
오.. response가 unknown 이군..?!🤔
There was a problem hiding this comment.
뭐 딱히 활용하진 않기도 하고 일단 unknown 해버림
(그리고 사실 잘모름 ㅋㄷ)
Comment on lines
-28
to
-29
| // FIXME: | ||
| // @ts-expect-error Round 타입에 START를 아직 추가하지 않아서 ts 에러가 발생해서 일단 막음 |
There was a problem hiding this comment.
옹 여기서 추가해준거구나!! 궁금증 해결완료 ㅎㅅㅎ
| @@ -16,6 +16,7 @@ export const POSITION_LIST = Object.entries(POSITION).map(([key, value]) => ({ | |||
| })); | |||
|
|
|||
| export const ROUND_INDEX_MAP: Record<Round, number> = { | |||
| START: -1, | |||
There was a problem hiding this comment.
네이밍이 index라 -1이라는 숫자가 조금 마음에 걸리지만... 쓰이는 곳들 봤을 때 -1로 하는게 우선 좋을듯..!
There was a problem hiding this comment.
ㅇㅇㅇ;; 굉장히 맘에 걸리지만 일단 가볼게...!!!
- 카드 컴포넌트에서 start, complete 라운드 고려 안하도록 - ts-expecte-error 주석 제거 - pm 페이지에서 시작 버튼 라벨과 비활성화 조건 변경
259ee10
to
0a0cb09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
체크리스트