Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOYEO-55] API 연동 (어드민, 설문 위주) #28

Merged
merged 17 commits into from
Aug 14, 2023
Merged

Conversation

young-do
Copy link
Collaborator

작업 내용

  • API 연동
    • 설문 페이지 (데이터 가져오고 응답 보내기까지)
    • 어드민 페이지 (데이터 가져오고 조정 api 호출까지만)
  • TODO:
    • 어드민 페이지에서 sse 연결하고 refetch or 캐시 클라이언트 수정 로직 반영
  • 주의
    • 이 PR 머지되면 방 생성한 다음에 작업 가능..ㅎ..ㅎ

체크리스트

  • Code Review 요청
  • Label 설정
  • PR 제목 규칙에 맞는지 확인

@young-do young-do added the ✨ Feature 기능 추가 label Aug 12, 2023
Copy link
Member

@haryung-lee haryung-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!👍

Comment on lines +7 to +8
type Response = API['createTeamBuilding']['response'];
type RequestBody = API['createTeamBuilding']['request']['body'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 일케 하니까 훨씬 깔끔하다!!👍

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4e435ed
Status: ✅  Deploy successful!
Preview URL: https://41e88e49.moyeomoyeo.pages.dev
Branch Preview URL: https://feature-moyeo-55.moyeomoyeo.pages.dev

View logs

@young-do young-do marked this pull request as ready for review August 14, 2023 11:03
@young-do young-do merged commit 6c753af into main Aug 14, 2023
1 check passed
@young-do young-do deleted the feature/MOYEO-55 branch August 14, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants