Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 네비게이션 관련 프로가드 문제 임시 해결 #112

Merged
merged 8 commits into from
Mar 14, 2024
Merged

[FIX] 네비게이션 관련 프로가드 문제 임시 해결 #112

merged 8 commits into from
Mar 14, 2024

Conversation

easyhooon
Copy link
Collaborator

  • 라이브러리 버전 수동 업데이트
  • 프로가드 관련 설정 추가 (치트키..)

@easyhooon
[CHORE] proguard 관련 네이밍 및 개행 수정
dab5f6d
@easyhooon
[FIX] navigation 관련 proguard 추가
f26295f
@easyhooon
[FEAT] library version up
1f1547a
@easyhooon
[FIX] proguard 치트키 추가
2f8e0cf 
난독화는 사실상 비활성화 되지만, 코드 최적화와 불필요한 리소스 제거와 같은 작업은 여전히 수행되므로, 프로가드 자체를 비활성화(isMinifyEnabled = false) 하는 것 보단 낫다고 판단
@easyhooon easyhooon added bug Something isn't working feature New feature or request labels Mar 13, 2024
@easyhooon easyhooon self-assigned this Mar 13, 2024
josushell
josushell approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@josushell josushell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

결국 keep이구만… 커밋에 써준 것처럼 현 시점에서는 난독화 자체 비활성화보다 더 좋은 방안인듯

@easyhooon easyhooon merged commit 2ad1ce2 into develop Mar 14, 2024
1 check failed
@easyhooon easyhooon deleted the fix/navigation-proguard branch March 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josushell josushell josushell approved these changes

Assignees

@easyhooon easyhooon

Labels
bug Something isn't working feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@easyhooon @josushell