Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sapplings don't grow like vanilla trees #9

Open
ghost opened this issue Jan 31, 2021 · 4 comments
Open

Sapplings don't grow like vanilla trees #9

ghost opened this issue Jan 31, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jan 31, 2021

The sapplings need a tremendous amount of empty space surrounding it and can't be replanted when cut down in a dense forest. You also can't place multiple sapplings together to make a large tree like vanilla.

@gdude2002 gdude2002 self-assigned this Mar 16, 2021
@gdude2002 gdude2002 added bug Something isn't working enhancement New feature or request labels Mar 16, 2021
@gdude2002
Copy link
Collaborator

Hey, thanks for the ticket!

I've noticed this one myself as well - the 5x5 box saplings require is pretty ridiculous, I agree, especially since that box must be free of blocks like torches and tall grass.

I plan on looking into this one, but as the tree generation stuff isn't exactly documented, I can't guarantee it'll be a quick fix.


As for 2x2 saplings for larger trees, it's not something we've really looked into yet. I'll have a chat with my partner about it.

@gdude2002
Copy link
Collaborator

Having investigated this further, it seems that it's just because the trees are huge.

We use some of vanilla's tree generation logic for our trees - the trunk and foliage are generated using Minecraft's own Large Oak placers, with some different values provided.

I suspect that the issue here is really just that the trees are huge. That said, I could make saplings grow under the foliage and logs that were part of other trees, even if those trees were not Sakura trees.

From what I'm reading of the code, the way the saplings behave is consistent with vanilla. It's unfortunate that it's not intuitive, although I'm not really sure what we can do about it.

I'll leave this issue open, in case someone comes along with an idea.

@gdude2002 gdude2002 added help wanted Extra attention is needed and removed bug Something isn't working labels Mar 18, 2021
@nullified33
Copy link

Having investigated this further, it seems that it's just because the trees are huge.

We use some of vanilla's tree generation logic for our trees - the trunk and foliage are generated using Minecraft's own Large Oak placers, with some different values provided.

I suspect that the issue here is really just that the trees are huge. That said, I could make saplings grow under the foliage and logs that were part of other trees, even if those trees were not Sakura trees.

From what I'm reading of the code, the way the saplings behave is consistent with vanilla. It's unfortunate that it's not intuitive, although I'm not really sure what we can do about it.

I'll leave this issue open, in case someone comes along with an idea.

maybe make saplings smaller unless there are 4 saplings

@gdude2002
Copy link
Collaborator

That doesn't really solve anything, it just means people would need more saplings to make the trees we have already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants