-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imports isolation in tests #710
Comments
I think that could be a consequence of running the CLI tests via CliRunner. It simulates a CLI execution environment, but isn't quite the same as running the commands separately from a real CLI. If we wanted to test that, we'd need something like a shell script (or possibly even a bats test suite) that runs the annif commands separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When working on PR #708, I accidentally removed this inline import:
Annif/annif/project.py
Line 205 in fb51292
This made
annif index
command fail:But this was not detected by tests for
index
command. Seems that some commands that are tested before importannif.suggestion
, and this import remains forindex
command.The tests should probably be some way more isolated to be able to detected this kind of possibility for bugs.
The text was updated successfully, but these errors were encountered: