[NFC] Modularize <exception>
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
7aec454
to
8965977
Compare
|
Note: Those headers and features are currently not exported thorugh libcu++ so running tests is not necessary |
8965977
to
2aa31b3
Compare
6453a92
to
cf6394a
Compare
fe2608b
to
0b483f2
Compare
6fc4b95
to
1da1db0
Compare
wmaxey
approved these changes
Mar 25, 2024
griwes
approved these changes
Apr 1, 2024
libcudacxx/include/cuda/std/detail/libcxx/include/__exception/terminate.h
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__exception/terminate.h
Outdated
Show resolved
Hide resolved
Comment on lines
+33
to
+45
| #if !defined(__cpp_sized_deallocation) || __cpp_sized_deallocation < 201309L | ||
| #define _LIBCUDACXX_HAS_NO_LANGUAGE_SIZED_DEALLOCATION | ||
| #endif | ||
|
|
||
| #if !defined(_LIBCUDACXX_BUILDING_LIBRARY) && _CCCL_STD_VER < 2014 && \ | ||
| defined(_LIBCUDACXX_HAS_NO_LANGUAGE_SIZED_DEALLOCATION) | ||
| # define _LIBCUDACXX_HAS_NO_LIBRARY_SIZED_DEALLOCATION | ||
| #endif | ||
|
|
||
| #if defined(_LIBCUDACXX_HAS_NO_LIBRARY_SIZED_DEALLOCATION) || \ | ||
| defined(_LIBCUDACXX_HAS_NO_LANGUAGE_SIZED_DEALLOCATION) | ||
| # define _LIBCUDACXX_HAS_NO_SIZED_DEALLOCATION | ||
| #endif |
There was a problem hiding this comment.
I wonder if this should go in __config instead.
There was a problem hiding this comment.
It is only ever used here and we cannot generically overload operator new on device anyway, so I would prefer to keep that located here
1da1db0
to
0284bc9
Compare
8251934
to
beab332
Compare
beab332
to
e62f45a
Compare
e62f45a
to
a67ea89
Compare
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modularizes header that are currently only used internally.
Those are
<exception>,<new>and<stdexcept>. With the changes here, we can include those headers even in__cuda_std__mode without breaking anything