Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default config_id for completions endpoint #451

Closed
rgstephens opened this issue Apr 13, 2024 · 2 comments · Fixed by #538
Closed

Use default config_id for completions endpoint #451

rgstephens opened this issue Apr 13, 2024 · 2 comments · Fixed by #538
Assignees
Labels
status: in progress Issues that are currently being worked on.
Milestone

Comments

@rgstephens
Copy link
Contributor

It would be nice if the completions endpoint was more compatible with the OpenAI endpoint so that tools that use this endpoint would work with guardrails without modification. I'd like to use the deep-chat widget for example.

My proposal is that if neither config_ids nor config_id are provided on the completions call, the value would be set to ["config"] as the default.

@drazvan
Copy link
Collaborator

drazvan commented Apr 15, 2024

Indeed. We could even use "model" as the configuration id. Thanks for the contribution!

@rgstephens
Copy link
Contributor Author

For my use case, the "model" value need to be empty.

@drazvan drazvan assigned Pouyanpi and unassigned drazvan May 21, 2024
@Pouyanpi Pouyanpi added the status: in progress Issues that are currently being worked on. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress Issues that are currently being worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants