{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":371007879,"defaultBranch":"master","name":"topmodel","ownerLogin":"NOAA-OWP","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-05-26T11:22:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/60660814?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718085307.0","currentOid":""},"activityList":{"items":[{"before":"34c25923bea38dda2d407ff720d7137e615f7a22","after":null,"ref":"refs/heads/PhilMiller/bmi-virtual-dtor","pushedAt":"2024-06-11T05:55:07.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"}},{"before":"c9aa4c8bfabead15d05c2e2011aebd3c486e470f","after":"ebd24a4b45123991217835fe6808d71cd1d5104c","ref":"refs/heads/master","pushedAt":"2024-06-11T05:54:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hellkite500","name":"Nels","path":"/hellkite500","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5186647?s=80&v=4"},"commit":{"message":"Replace BMI_SUCCESS/FAILURE macros with static constants per csdms/bmi-c#12","shortMessageHtmlLink":"Replace BMI_SUCCESS/FAILURE macros with static constants per csdms/bm…"}},{"before":null,"after":"34c25923bea38dda2d407ff720d7137e615f7a22","ref":"refs/heads/PhilMiller/bmi-virtual-dtor","pushedAt":"2024-06-11T05:48:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Replace BMI_SUCCESS/FAILURE macros with static constants per csdms/bmi-c#12","shortMessageHtmlLink":"Replace BMI_SUCCESS/FAILURE macros with static constants per csdms/bm…"}},{"before":"e8d7683c29737e9172568a0b65c0aab4ce08c96d","after":null,"ref":"refs/heads/madMatchstick-patch-1","pushedAt":"2024-04-26T18:53:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"madMatchstick","name":"JessicaGarrett-NOAA","path":"/madMatchstick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30940444?s=80&v=4"}},{"before":"a4cb3ba3d64e41a506ebbdd49c4215f8041b88e1","after":"c9aa4c8bfabead15d05c2e2011aebd3c486e470f","ref":"refs/heads/master","pushedAt":"2024-04-26T18:30:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"SnowHydrology","name":"K. Jennings","path":"/SnowHydrology","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32177682?s=80&v=4"},"commit":{"message":"use 'os-latest` in ngen ci (#50)","shortMessageHtmlLink":"use 'os-latest` in ngen ci (#50)"}},{"before":null,"after":"e8d7683c29737e9172568a0b65c0aab4ce08c96d","ref":"refs/heads/madMatchstick-patch-1","pushedAt":"2024-04-26T17:29:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"madMatchstick","name":"JessicaGarrett-NOAA","path":"/madMatchstick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30940444?s=80&v=4"},"commit":{"message":"use 'os-latest` in ngen ci","shortMessageHtmlLink":"use 'os-latest` in ngen ci"}},{"before":"9da9b68ab55255a7a298bffaf1bc7070fabc31b6","after":null,"ref":"refs/heads/PhilMiller/warnings-2","pushedAt":"2024-04-02T15:11:31.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"}},{"before":"5c3929d07fed3da937a2edc7c9db42fae20d785a","after":"a4cb3ba3d64e41a506ebbdd49c4215f8041b88e1","ref":"refs/heads/master","pushedAt":"2024-04-02T15:07:09.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"aaraney","name":"Austin Raney","path":"/aaraney","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39420640?s=80&v=4"},"commit":{"message":"Error-check fgets and fscanf calls inside input file reading routines","shortMessageHtmlLink":"Error-check fgets and fscanf calls inside input file reading routines"}},{"before":"a8d081cd5895b51b77805d9e062e51a762ceb1af","after":"9da9b68ab55255a7a298bffaf1bc7070fabc31b6","ref":"refs/heads/PhilMiller/warnings-2","pushedAt":"2024-04-01T20:29:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Error-check fgets and fscanf calls inside input file reading routines","shortMessageHtmlLink":"Error-check fgets and fscanf calls inside input file reading routines"}},{"before":"a7ae26a3cab0c1c593d85b0744548524b863cfcc","after":"a8d081cd5895b51b77805d9e062e51a762ceb1af","ref":"refs/heads/PhilMiller/warnings-2","pushedAt":"2024-04-01T18:17:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Enable minimal optimization to get warning-generating control/data-flow analysis","shortMessageHtmlLink":"Enable minimal optimization to get warning-generating control/data-fl…"}},{"before":"ce1272950a32652fc4a9b6a726e79e36fd737caf","after":"a7ae26a3cab0c1c593d85b0744548524b863cfcc","ref":"refs/heads/PhilMiller/warnings-2","pushedAt":"2024-04-01T17:56:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Enable minimal optimization to get warning-generating control/data-flow analysis","shortMessageHtmlLink":"Enable minimal optimization to get warning-generating control/data-fl…"}},{"before":null,"after":"ce1272950a32652fc4a9b6a726e79e36fd737caf","ref":"refs/heads/PhilMiller/warnings-2","pushedAt":"2024-04-01T17:46:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Fix variable name in CMake arguments in CI","shortMessageHtmlLink":"Fix variable name in CMake arguments in CI"}},{"before":"8282314d21e26e57cce9409027bad52858792b55","after":null,"ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T23:55:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"}},{"before":"b5ae9bbd4f1429958c5efff33d91d8b8f905b227","after":"5c3929d07fed3da937a2edc7c9db42fae20d785a","ref":"refs/heads/master","pushedAt":"2024-03-29T23:55:07.000Z","pushType":"pr_merge","commitsCount":6,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Free Bmi model object allocation to fix only reported leak","shortMessageHtmlLink":"Free Bmi model object allocation to fix only reported leak"}},{"before":"d96bb5298c7a06f527947aa9ef69bda06383b5a8","after":"8282314d21e26e57cce9409027bad52858792b55","ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T22:31:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Free Bmi model object allocation to fix only reported leak","shortMessageHtmlLink":"Free Bmi model object allocation to fix only reported leak"}},{"before":"78b4dfbc52321fe982946f71685576b0fb4afc87","after":"d96bb5298c7a06f527947aa9ef69bda06383b5a8","ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T22:18:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Free Bmi model object allocation to fix only reported leak","shortMessageHtmlLink":"Free Bmi model object allocation to fix only reported leak"}},{"before":"c542279b8e608391c4f56fd65f8edb464af434e2","after":"78b4dfbc52321fe982946f71685576b0fb4afc87","ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T21:54:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"In CI, build topmodel with -Werror","shortMessageHtmlLink":"In CI, build topmodel with -Werror"}},{"before":"4c65a5e240c8f24bc1819ef6631e792be0523ab1","after":"c542279b8e608391c4f56fd65f8edb464af434e2","ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T21:37:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Correct error check on fscanf","shortMessageHtmlLink":"Correct error check on fscanf"}},{"before":"cde856ce2deee450a95867f5e7142fa50d6bcdc9","after":"4c65a5e240c8f24bc1819ef6631e792be0523ab1","ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T21:28:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Check for errors in Initialize","shortMessageHtmlLink":"Check for errors in Initialize"}},{"before":"4bfbca70ea14a336bcfcfb31260072cc5abd1661","after":"cde856ce2deee450a95867f5e7142fa50d6bcdc9","ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T20:35:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"TEMP: exit on topodex hugeness warning","shortMessageHtmlLink":"TEMP: exit on topodex hugeness warning"}},{"before":"a76ccdf40676ba06f22ead9437c009f0b301dcf7","after":"4bfbca70ea14a336bcfcfb31260072cc5abd1661","ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T20:28:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Try dynamically heap allocating 'ex' instead of a stack-allocated VLA to avoid ASan stack-overflow","shortMessageHtmlLink":"Try dynamically heap allocating 'ex' instead of a stack-allocated VLA…"}},{"before":null,"after":"a76ccdf40676ba06f22ead9437c009f0b301dcf7","ref":"refs/heads/PhilMiller/warnings","pushedAt":"2024-03-29T20:14:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"PhilMiller","name":"Phil Miller - NOAA","path":"/PhilMiller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/126464?s=80&v=4"},"commit":{"message":"Error check file fgets()/fscanf() and return BMI_FAILURE as appropriate","shortMessageHtmlLink":"Error check file fgets()/fscanf() and return BMI_FAILURE as appropriate"}},{"before":"479e3c70eebfcf038093abcb0edf5dab5c1a4262","after":"b5ae9bbd4f1429958c5efff33d91d8b8f905b227","ref":"refs/heads/master","pushedAt":"2024-03-29T19:05:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madMatchstick","name":"JessicaGarrett-NOAA","path":"/madMatchstick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30940444?s=80&v=4"},"commit":{"message":"Remove standard topmodel output when running from ngen (#41)\n\n* testing fork\r\n\r\n* removing test file\r\n\r\n* Failed attempt at implementing calibratable params\r\n\r\n* backup/scratch working files to be removed later\r\n\r\n* fixing an accidental comment included with this file\r\n\r\n* remove nstep dt from config and set to 1 in else block initalize - fixing accidental comment associated w/this file\r\n\r\n* refactoring init to smaller functions\r\n\r\n* refactored init() into smaller functions\r\n\r\n* refactored init() into smaller functions\r\n\r\n* refactored init() to smaller functions\r\n\r\n* refactoring init() to smaller functions - update comments\r\n\r\n* refactored init() to smaller functions - added missing \\+\r\n\r\n* removing file that was not intended to push originally, and was only used locally\r\n\r\n* adding refactored init() function to update calibratable parameters\r\n\r\n* better organizing and adding comments in code\r\n\r\n* removing folder that was not not originally intended to push\r\n\r\n* updating commenting and including new init functions in bmi_topmodel.c\r\n\r\n* edited init() prototype tp match change of order of input variables in topmodel.c\r\n\r\n* changed order of init() input variables so outputs come last. Also updated comments relate dto functions\r\n\r\n* imporved comments and organization\r\n\r\n* Toward updating calibratable params with refactored functions\r\n\r\n* added lines to include chv, rv as paramters and include the prototypes of the new functions\r\n\r\n* updating comments for clarity\r\n\r\n* actively working on using refactored init() functions to update calibratable parameters\r\n\r\n* added chv & rv to model data structure. Updated order of init() prototype input variables.\r\n\r\n* updated Set_value function to incorporate calibratable parameters. Still testing.\r\n\r\n* updated order of init() input variables. Added some print statements for printing out updates relevant to calibratable parameters.\r\n\r\n* updated output messages related to calibratable parameters\r\n\r\n* made small edits to Set_value - removed uneeded calibratable parameters\r\n\r\n* updated code related to calibrated parameters in Set_value().\r\n\r\n* edited order of refactored functions to be more logical. added print statements related to calibratable parameters.\r\n\r\n* added a few print lines for troubleshooting. Unexpected behavior related to tch.\r\n\r\n* removed print statements no longer needed/relevant\r\n\r\n* removed/edited comments no longer needed\r\n\r\n* small updates to comments\r\n\r\n* updating some comments\r\n\r\n* updated comments\r\n\r\n* removed uneeded comments\r\n\r\n* corrected a typo in comments\r\n\r\n* add helper function to shift Q array by one\r\n\r\n* properly account for time delayed flow accumulation in Q\r\n\r\n* use dynamic tch array in convert_dist_to_histords\r\n\r\n* use dynamic tch array in calc_time_delay_histogram\r\n\r\n* simplify ordinate area adjustment and validate oridnates sum to 1\r\n\r\n* ensure Q is dynamically initialized\r\n\r\n* Add macros for model limit warnings\r\n\r\n* Remove hard coded program limits\r\n\r\n* fix logical operator\r\n\r\n* small combine loop optimization\r\n\r\n* add debug and sanitize flags to unit test build\r\n\r\n* fix bug in printing value from pointer\r\n\r\n* comment bmi Q initialization\r\n\r\n* temporarly 'fix' standalone mode allocation of Q in driver\r\n\r\n* Corrected amount Q is shifted by at each timestep to include num_delay+num_time_delay_histo_ords, instead of just num_time_dealy_histo_ords. Also edited a print statement, and an error to provide assistance to user about how to fix error.\r\n\r\n* Added stand_alone to init() and init_discharge, and edited to allocate Q differently depending on if stand alon emode or not. Seeing discrepancies between master stand_alone results and current stand_alone results. Differences exist before these edits.\r\n\r\n* fixed error - szq and sum_histogram_ordinates were reported incorrectly to output when in stand_alone mode\r\n\r\n* cleaned up some indentation/formatting\r\n\r\n* Edited so standard topmodel output files are only written when in stand alone mode (i.e., stand_alone == 1)\r\n\r\n* added if statements so info about calibratable parameters is only printed when in debug mode\r\n\r\n* added stand_alone as input to water balance to fix seg fault when in stand_alone mode\r\n\r\n* merging w/master\r\n\r\n---------\r\n\r\nCo-authored-by: hellkite500 ","shortMessageHtmlLink":"Remove standard topmodel output when running from ngen (#41)"}},{"before":"f9df576febd769aad63b97b226ae1efa36b9df86","after":"479e3c70eebfcf038093abcb0edf5dab5c1a4262","ref":"refs/heads/master","pushedAt":"2024-03-27T15:52:30.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"hellkite500","name":"Nels","path":"/hellkite500","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5186647?s=80&v=4"},"commit":{"message":"test: ensure chv an rv are tested parameters in unit test","shortMessageHtmlLink":"test: ensure chv an rv are tested parameters in unit test"}},{"before":"833058925fb74eb99e837af407e9ad7f426f20f8","after":null,"ref":"refs/heads/topmodIntermediate","pushedAt":"2024-03-27T15:15:32.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Ben-Choat","name":null,"path":"/Ben-Choat","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96442889?s=80&v=4"}},{"before":null,"after":"833058925fb74eb99e837af407e9ad7f426f20f8","ref":"refs/heads/topmodIntermediate","pushedAt":"2024-03-27T15:13:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Ben-Choat","name":null,"path":"/Ben-Choat","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/96442889?s=80&v=4"},"commit":{"message":"Fix memory error when chv and rv are used as calibration parameters; see PR46 on NOAA-OWP/topmodel master","shortMessageHtmlLink":"Fix memory error when chv and rv are used as calibration parameters; …"}},{"before":"e2e90d6f547acf2a1b2b9a7d681dbcde30add978","after":"f9df576febd769aad63b97b226ae1efa36b9df86","ref":"refs/heads/master","pushedAt":"2024-03-20T20:32:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"SnowHydrology","name":"K. Jennings","path":"/SnowHydrology","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32177682?s=80&v=4"},"commit":{"message":"Required updates for integration workflow (#45)\n\n* include NOM lib flag and don't init topmod submod after local code copy\r\n\r\n* comment update","shortMessageHtmlLink":"Required updates for integration workflow (#45)"}},{"before":"d67d5f5d89c0b2c86ea590e9083d425a9273610b","after":"e114549edf4e4d8ad672d26f6e01aeca9f39e314","ref":"refs/heads/jlg/integration-workflow-fix","pushedAt":"2024-03-20T20:02:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"madMatchstick","name":"JessicaGarrett-NOAA","path":"/madMatchstick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30940444?s=80&v=4"},"commit":{"message":"comment update","shortMessageHtmlLink":"comment update"}},{"before":"e2e90d6f547acf2a1b2b9a7d681dbcde30add978","after":"d67d5f5d89c0b2c86ea590e9083d425a9273610b","ref":"refs/heads/jlg/integration-workflow-fix","pushedAt":"2024-03-20T19:57:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"madMatchstick","name":"JessicaGarrett-NOAA","path":"/madMatchstick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30940444?s=80&v=4"},"commit":{"message":"include NOM lib flag and don't init topmod submod after local code copy","shortMessageHtmlLink":"include NOM lib flag and don't init topmod submod after local code copy"}},{"before":null,"after":"e2e90d6f547acf2a1b2b9a7d681dbcde30add978","ref":"refs/heads/jlg/integration-workflow-fix","pushedAt":"2024-03-20T19:52:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"madMatchstick","name":"JessicaGarrett-NOAA","path":"/madMatchstick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30940444?s=80&v=4"},"commit":{"message":"cleaned up some indentation/formatting","shortMessageHtmlLink":"cleaned up some indentation/formatting"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYdMwEAA","startCursor":null,"endCursor":null}},"title":"Activity · NOAA-OWP/topmodel"}