New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug #77

Open

ajkhattak opened this issue Feb 6, 2023 · 0 comments

Contributor

ajkhattak commented Feb 6, 2023

The excess water from infiltration is added to the direct_runoff (https://github.com/NOAA-OWP/cfe/blob/master/src/cfe.c#L181), however, excess water from percolation is added to the mass balance but not to the direct runoff (https://github.com/NOAA-OWP/cfe/blob/master/src/cfe.c#L208), which closes the mass balance locally but excess water does not contribute to GIUH runoff.

So my understanding is that if the mass balance is done outside the code as a post-processing, it may not close. Unless I am missing something...

Expected code change

In the block at https://github.com/NOAA-OWP/cfe/blob/master/src/cfe.c#L204, put the following line to add excess water to the direct runoff.
direct_output_runoff_m+=diff;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment