Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PET code should no longer reside in CFE #45

Open
SnowHydrology opened this issue Feb 11, 2022 · 0 comments
Open

PET code should no longer reside in CFE #45

SnowHydrology opened this issue Feb 11, 2022 · 0 comments
Assignees
@lcunha0118 @SnowHydrology @rlmcdaniel

Comments

@SnowHydrology
Copy link
Contributor

PET already exists as a standalone repo. We should stick to best practices and remove the duplicate code from the CFE repo.

Current behavior

The code for calculating PET currently resides in three locations:

  1. The CFE repo
  2. The ngen repo
  3. Its own PET repo

Expected behavior

PET should only reside in one location (its own repo). There are two solutions:

  1. Point to the PET repo as an external submodule in CFE
  2. Suggest individuals use the ngen framework if they want to run PET + CFE

We'll probably want to do the former as it doesn't prevent us from doing the latter as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcunha0118 lcunha0118

@SnowHydrology SnowHydrology

@rlmcdaniel rlmcdaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lcunha0118 @SnowHydrology @rlmcdaniel