-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the reading of ww3_shel.inp #679
Comments
There is already a function to read ww_shel.inp data in wave_shel_inp.F90, is the request to use this function in ww3_shel.F90? |
@arunchawla-NOAA yes, this way we don't have duplicative code and if code needs updated its done once for both places. |
@arunchawla-NOAA, this has been my task. I've started it but was pulled to higher priority items. It will take a small dedicated chunk of time that I can move through the duplicative regions and refactor the duplicated code out. |
Is your feature request related to a problem? Please describe.
Create a separate routine to read ww3_shel.inp so that both ww3_shel program and the mesh based cap can use the same routine for reading the ww3_shel.inp file (and ww3_shel.nml).
Describe the solution you'd like
New subroutine to read ww3_shel.inp to reduce repeated code, which will help with code maintenance.
Describe alternatives you've considered
All initialization needs for ww3_shel.inp could be moved into a subroutine.
Additional context
This is part of merging #641 to the develop branch
The text was updated successfully, but these errors were encountered: