Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z-index is not imported or exported with GeoJSONs #240

Open
BPdeRooij opened this issue Jul 11, 2024 · 2 comments
Open

z-index is not imported or exported with GeoJSONs #240

BPdeRooij opened this issue Jul 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@BPdeRooij
Copy link
Contributor

Describe the bug
The z-index is not taken into account when importing or exporting annotations with GeoJSON.

To Reproduce
Create a WsiAnnotations object containing annotations with z-indices. Calling WsiAnnotations.as_geojson() fails to export z-index of the annotations. When importing annotations with WsiAnnotations.from_geojson(), z-index is also ignored.

Expected behavior
WsiAnnotations.as_geojson, WsiAnnotations.from_geojson and _geometry_to_geojson should all be able to handle annotations with z-indices correctly.

Environment
dlup version: 0.5.1
How installed: installed from main branch
Python version: 3.10
Operating System: Linux

Additional context
A working fix can be found in this branch.

@BPdeRooij BPdeRooij added the bug Something isn't working label Jul 11, 2024
@jonasteuwen
Copy link
Contributor

I don't think it's an issue as the export should export it without needing to sort again, the output itself is already sorted, in the GeoJSON order. There is a test that checks if reading back gives the same result

@BPdeRooij
Copy link
Contributor Author

The annotations are outputted in the correct order, but information is lost in the process. Including the z-index in the GeoJSON properties when exporting (or importing) would not break GeoJSON conventions and would ensure that all information is preserved. I believe it would be useful to include the z-index for completeness and reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants