Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple holes in annotations are not read correctly #223

Open
moerlemans opened this issue Apr 24, 2024 · 1 comment
Open

Multiple holes in annotations are not read correctly #223

moerlemans opened this issue Apr 24, 2024 · 1 comment
Assignees
@moerlemans

Comments

@moerlemans
Copy link
Contributor

Issue
See

dlup/dlup/annotations.py

Line 229 in 3509bc9

multi_polygon = shapely.geometry.MultiPolygon(
. When loading annotations with multiple holes the holes can be of different number of point and therefore casting them to a numpy array doesn't work.

Reproduce
Load any annotations with multiple holes

image
@moerlemans moerlemans self-assigned this Apr 24, 2024
@moerlemans moerlemans linked a pull request Apr 24, 2024 that will close this issue
Fixes reading of multiple holes in annotations #224
Closed
@jonasteuwen
Copy link
Contributor

I think this will be fixed in #228. Can you verify?

@jonasteuwen jonasteuwen reopened this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moerlemans moerlemans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes reading of multiple holes in annotations NKI-AI/dlup
2 participants
@jonasteuwen @moerlemans