Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSX/TSX #175

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Add JSX/TSX #175

merged 3 commits into from
Aug 5, 2024

Conversation

toni-santos
Copy link
Collaborator

Closes #173

This pull request adds support for TSX in content-scripts.

@toni-santos toni-santos self-assigned this Jul 26, 2024
@toni-santos
Copy link
Collaborator Author

Currently we are able to get TSX working with texsaur. There are some considerations to take, mainly how we are going to go about using typescript alongside this package as it offers quite some options. Regardless, we should still do some "house keeping" in this PR seeing as we are messing around with the content-scripts folder.

@thePeras
Copy link
Member

thePeras commented Aug 1, 2024

I quickly try to test this out by asking our friend to translate the layout.js to layout.tsx and .jsx, and I wasn't able to make it work. Can you give us an example of how can we use it?

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great, what an excellent DX!
✅ 🛫

@toni-santos toni-santos merged commit 5d435e1 into develop Aug 5, 2024
@thePeras thePeras deleted the feature/jsx branch August 5, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use JSX/TSX
2 participants