Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify which tests failed on PRs #2452

Open
robyngit opened this issue Jun 18, 2024 · 1 comment
Open

Clarify which tests failed on PRs #2452

robyngit opened this issue Jun 18, 2024 · 1 comment
Labels
documentation Creating and enhancing app documentation enhancement

Comments

@robyngit
Copy link
Member

Because multiple checks like linting, formatting, and unit tests are bundled together into one GitHub action job, it's not immediately clear which tests are failing on PRs. We are letting ESlint errors through some PRs as we slowly improve our code quality, but it seems like we might be inadvertently allowing some test failures to pass unnoticed because of how errors are reported. Whether one or all four fail, it just shows as an overall failure in the PR.

This issue entails making a clearer distinction between types of failures in PRs. Some ideas:

  • Showing ESlint errors as warnings rather than errors?
  • Running an individual job for each of the 4 types of tests
  • Auto commenting on PRs with a summary of the test outputs

Related to: #2425

@robyngit robyngit added enhancement documentation Creating and enhancing app documentation labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Creating and enhancing app documentation enhancement
Projects
None yet
Development

No branches or pull requests

1 participant