Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support selected new numpy-consistent Data methods #328

Open
3 tasks
sadielbartholomew opened this issue Feb 21, 2022 · 1 comment
Open
3 tasks

Support selected new numpy-consistent Data methods #328

sadielbartholomew opened this issue Feb 21, 2022 · 1 comment
Labels
API review (4.0.0) dask Relating to the use of Dask enhancement New feature or request

Comments

@sadielbartholomew
Copy link
Member

After or during the LAMA to Dask conversion (#182) we should review the Data methods we support, especially because LAMA didn't yet support binary operations in a performant way, but Dask enables those, and particularly also for data operations like mathematical functions where we don't seem to have very good coverage relative to the possible methods supported by NumPy (see ours vs. numpys).

The following can be used as a list of methods to add, or to prioritise adding; please add to the list as appropriate, particularly with user requests or where a method seems particularly useful in the context of cf to add (try to include some contextual notes):

  • arctan2: already largely coded up but commented out as it is a binary operation and therefore was not possible to do in a performant way with the current LAMA (see Support binary operations e.g. arctan2 division #38);
  • sqrt: user request by @bnlawrence (I pointed out f**0.5 works for this, etc., but the method form was preferred and requested);
  • cbrt: why not add if we are adding the above anyway, where all other more niche roots can be covered by the ** operator;
    ...
@sadielbartholomew sadielbartholomew added the enhancement New feature or request label Feb 21, 2022
@davidhassell
Copy link
Collaborator

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API review (4.0.0) dask Relating to the use of Dask enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants