Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cf.aggregate fails when field units are non-valid #229

Closed
davidhassell opened this issue Jul 9, 2021 · 0 comments · Fixed by #233
Closed

cf.aggregate fails when field units are non-valid #229

davidhassell opened this issue Jul 9, 2021 · 0 comments · Fixed by #233
Assignees
@davidhassell
Labels
aggregation Rerlating to metadata-based field and domain aggregation bug Something isn't working

Comments

@davidhassell
Copy link
Collaborator

davidhassell commented Jul 9, 2021 •
edited
Loading

At v3.10.0, if otherwise aggregatable fields have non-valid units (such as kg -m-2 s-, cf.aggregate fails, ultimately when cf.Data.concatenate refuses to aggregate data with non-equivalent units. Since cfunits v3.3.1, non-valid units are no longer equivalent.

In this case, cf.aggregate needs to return, unaggregated, the fields with bad units, and report that it has done so.
@davidhassell davidhassell added the bug Something isn't working label Jul 9, 2021
@davidhassell davidhassell self-assigned this Jul 9, 2021
@davidhassell davidhassell changed the title cf.aggreaget fails when field units are non-valid cf.aggregate fails when field units are non-valid Jul 9, 2021
@davidhassell davidhassell mentioned this issue Jul 9, 2021
Merged
@davidhassell davidhassell added the aggregation Rerlating to metadata-based field and domain aggregation label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhassell davidhassell

Labels
aggregation Rerlating to metadata-based field and domain aggregation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for cf.aggregate failures when field units are non-valid davidhassell/cf-python
1 participant
@davidhassell