Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly formatted "logging.info" statement causes a hang in cf.Field.collapse #217

Closed
davidhassell opened this issue May 26, 2021 · 0 comments · Fixed by #218
Closed

Incorrectly formatted "logging.info" statement causes a hang in cf.Field.collapse #217

davidhassell opened this issue May 26, 2021 · 0 comments · Fixed by #218
Assignees
@davidhassell
Labels
bug Something isn't working

Comments

@davidhassell
Copy link
Collaborator

At 3.9.0, some rogue commas can cause a hang to occur

# cf/field.py
            logger.info(
                "  After collapse of data:\n"
                f"    f.shape = {f.shape}\n"
                f"    f.dtype = {f.dtype}\n",
                f"collapse_axes = {collapse_axes}",
            )  # pragma: no cover

https://github.com/NCAS-CMS/cf-python/blob/v3.9.0/cf/field.py#L9894-L9899

All of the commas in this snippet should be removed.
@davidhassell davidhassell added the bug Something isn't working label May 26, 2021
@davidhassell davidhassell self-assigned this May 26, 2021
@davidhassell davidhassell added this to the 3.10.0 milestone May 26, 2021
@davidhassell davidhassell changed the title Incorrectly formatted "logging.info" statement causes a hang Incorrectly formatted "logging.info" statement causes a hang in cf.collapse May 26, 2021
@davidhassell davidhassell changed the title Incorrectly formatted "logging.info" statement causes a hang in cf.collapse Incorrectly formatted "logging.info" statement causes a hang in cf.Field.collapse May 26, 2021
@davidhassell davidhassell removed this from the 3.10.0 milestone May 26, 2021
davidhassell added a commit to davidhassell/cf-python that referenced this issue May 26, 2021
@davidhassell
update for NCAS-CMS#217
c9ac7e8
@davidhassell davidhassell mentioned this issue May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhassell davidhassell

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix logging syntax davidhassell/cf-python
1 participant
@davidhassell