Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for argmax and new method argmin #135

Open
sadielbartholomew opened this issue Oct 14, 2020 · 1 comment
Open

Refactor for argmax and new method argmin #135

sadielbartholomew opened this issue Oct 14, 2020 · 1 comment
Labels
API review (4.0.0) enhancement New feature or request

Comments

@sadielbartholomew
Copy link
Member

We currently support an argmax method (see e.g. here) on the Data and Field classes, but not an equivalent argmin.

We've noted to add in argmin in time for the next minor release, but to do so by refactoring somewhat to create a common base for these methods (and potentially other similar ones).

@sadielbartholomew sadielbartholomew added the enhancement New feature or request label Oct 14, 2020
@sadielbartholomew sadielbartholomew added this to the 3.8.0 milestone Oct 14, 2020
@davidhassell davidhassell removed this from the 3.8.0 milestone Mar 3, 2021
@davidhassell
Copy link
Collaborator

Removing the 3.8.0 milestone, as the dask work (#182) will now take place first, and will affect the implementation of argmin/argmax. So this will be addressed at a version soon after 4.0.0 (i.e. the first dask version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API review (4.0.0) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants