Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Feature: modern directory structure #641

Merged
merged 1 commit into from
Sep 21, 2022
Merged

New Feature: modern directory structure #641

merged 1 commit into from
Sep 21, 2022

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented Jun 7, 2022 •
edited
Loading

TYPE: new feature

KEYWORDS: directory structure, CMake, testing

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES: Modern build directory structures, allow for a CMakelist in the top directory and better testing integration. trunk/NDHMS is currently a symlink to allow time for users to switch over. CMakeLists and Makefiles have been modified.

TESTS CONDUCTED: built with CMake and Makefile, then tested a brief Croton run.

NOTE: the test directory needs a CMakeLists.txt file. I am adding unit tests and will clean up the test directory for that.

Checklist

  • Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Documentation included
  • Short description in the Development section of NEWS.md

@scrasmussen
New Feature: trunk/NDHMS has been moved to src/ directory to follow m…
e85a38d 
…odern

build directory structures, allow for a CMakelist in the top directory and
better testing integration. trunk/NDHMS is currently a symlink to allow time
for users to switch over. CMakeLists and Makefiles have been modified.
@rcabell rcabell self-requested a review September 21, 2022 20:31
@rcabell rcabell merged commit 57dce00 into NCAR:master Sep 21, 2022
@scrasmussen scrasmussen deleted the feature/modern_dir_structure branch October 17, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcabell rcabell rcabell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scrasmussen @rcabell