Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idealized forcings require hourly timestep #656

Open
aubreyd opened this issue Oct 5, 2022 · 0 comments
Open

Idealized forcings require hourly timestep #656

aubreyd opened this issue Oct 5, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@aubreyd
Copy link
Collaborator

aubreyd commented Oct 5, 2022

The idealized forcing option is coded up in a way that it only works properly with hourly forcing cycling. It will not error out if you choose a different forcing timestep, but will produce odd results.

Expected Behavior

Error if forcing_timestep is not 3600 sec and forc_typ = 4
OR
Use input forcing_timestep to adapt idealized forcings to match (better!).

Current Behavior

Model runs happily along with increments of 24 (so, for example, you will see 4 diurnal cycles per day if you are running with 15-min forcing timestep).

Possible Solution

Bring in forcing timestep value from HRLDAS namelist and use this to figure out the number of daily timesteps needed (currently hard-coded to 24).

Steps to Reproduce (for bugs)

Change FORCING_TIMESTEP to <> 3600 and active FORC_TYP = 4.

Your Environment

Mars!

(bug discovered by @then6702... thanks, Tom!)

@aubreyd aubreyd added the bug Something isn't working label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant