feature_id dimension in HYDRO_RST and Route_Link must match

[jmccreight]

I consider this a bug, because a machine should catch blatant user errors when possible.

Expected Behavior

WHen restarting a run using NWM (or other configs potentially), the restart (if requested) dimension for feature_ids (aka links)
should match that dimension in the Route_Link file.

The suggestion is that the dimensions be checked every time. I can not think of an acceptable situation where the two do not match.

One should go further and store the feature_ids in the restart files. Then the feature_ids should themselves be checked at restart, after the dimension length itself is checked.

Current Behavior

Currently the code just goes on it's merry way, presumably with uninitalized or incorrectly collated states and links.

Possible Solution

This should be easy.

Steps to Reproduce (for bugs)

Contact me for a test case on cheyenne.

Your Environment

• Version of the code used:
• Operating System and version:
• Compiler and version:
• Other relevant information: