NoahMP driver does not have an MPI abort

[jmccreight]

the subrtouine "wrf_abort"

wrf_hydro_nwm_public/trunk/NDHMS/Land_models/NoahMP/Utility_routines/module_wrf_utilities.F

Line 47 in 7cf193b

SUBROUTINE wrf_abort

does not treat MPI. Running under MPI, the stop causes MPI to hang as it is improperly(not) finalized

Expected Behavior

The MPI code should return and not hang. You can not programatically assess such failures without writing elaborate process kills.

Current Behavior

the code hangs on wrf_abort

Possible Solution

use the pattern

wrf_hydro_nwm_public/trunk/NDHMS/MPP/mpp_land.F

Line 2495 in 7cf193b

subroutine mpp_land_abort()

Steps to Reproduce (for bugs)

I can reproduce it but it takes some custom data that I have on my laptop.

Your Environment

• Version of the code used: current upstream master
• Operating System and version: nix
• Compiler and version: gnu
• Other relevant information: