Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: job convenience args for output and restart freq should be banished in the tests #337

Open
jmccreight opened this issue Jul 26, 2019 · 0 comments

Comments

@jmccreight
Copy link
Collaborator

jmccreight commented Jul 26, 2019

The options should only come from the testing config namelists/jsons.

For example:

restart_freq_hr=24,
output_freq_hr=24

There are more, perhaps better summarized by this:

(368) jamesmcc@cheyenne1[1107]:~/WRF_Hydro/wrf_hydro_nwm_public/tests> grep restart_freq_hr *py
test_1_fundamental.py:        restart_freq_hr=24,
test_1_fundamental.py:        restart_freq_hr=24,
test_1_fundamental.py:        restart_freq_hr=24,
test_1_fundamental.py:        candidate_sim_restart.jobs[0].restart_freq_hr_hydro == \
test_1_fundamental.py:        candidate_sim_restart.jobs[0].restart_freq_hr_hrldas, \
test_1_fundamental.py:    assert delay_restart_hr % candidate_sim_restart.jobs[0].restart_freq_hr_hydro == 0, \
test_supp_1_channel_only.py:        restart_freq_hr=6,
test_supp_1_channel_only.py:        restart_freq_hr=6,
test_supp_1_channel_only.py:        restart_freq_hr=6,
test_supp_1_channel_only.py:        candidate_channel_only_sim.jobs[0].restart_freq_hr_hydro == \
test_supp_1_channel_only.py:        candidate_channel_only_sim.jobs[0].restart_freq_hr_hrldas, \
test_supp_1_channel_only.py:    assert delay_restart_hr % candidate_channel_only_sim.jobs[0].restart_freq_hr_hydro == 0, \
test_supp_2_nwm_output.py:        restart_freq_hr=1,
test_supp_2_nwm_output.py:    # reference_nwm_output_sim_copy.jobs[0].restart_freq_hr = 1
test_supp_2_nwm_output.py:        restart_freq_hr=1,
test_supp_2_nwm_output.py:    # candidate_nwm_output_sim_copy.jobs[0].restart_freq_hr = 1
(368) jamesmcc@cheyenne1[1108]:~/WRF_Hydro/wrf_hydro_nwm_public/tests> grep output_freq_hr *py
test_1_fundamental.py:        output_freq_hr=24
test_1_fundamental.py:        output_freq_hr=24
test_1_fundamental.py:        output_freq_hr=24
test_supp_1_channel_only.py:        output_freq_hr=1
test_supp_1_channel_only.py:        output_freq_hr=1
test_supp_1_channel_only.py:        output_freq_hr=1
test_supp_2_nwm_output.py:        output_freq_hr=1
test_supp_2_nwm_output.py:        output_freq_hr=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant