Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYDRO_RST lake dimension should be enforced to match LAKEPARM #291

Open
jmccreight opened this issue Apr 24, 2019 · 1 comment
Open

HYDRO_RST lake dimension should be enforced to match LAKEPARM #291

jmccreight opened this issue Apr 24, 2019 · 1 comment
Assignees

Comments

@jmccreight
Copy link
Collaborator

No description provided.

@laurareads
Copy link
Contributor

Expected behavior: if a HYDRO_RST file is provided with dimension "lakes" = x, then the model should ensure that this dimension matches the feature_id dimension in LAKEPARM.nc. If these do not match, the model should crash. This is imperative because the HYDRO_RST file is ordered according to LAKEPARM, thus if the dimension does not match, the retrieval and assignment is garbled.

Current behavior: The model will execute given a HYDRO_RST with a "lakes" dim that does not match feature_id in LAKEPARM. Then in the next time step, the model will adjust the HYDRO_RST "lakes" count according to the feature_id dim in LAKEPARM. Thus the user does not know anything went awry.

@rcabell rcabell self-assigned this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants