Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model does NOT crash with incorrect forcing dimensions FORCE TYPE 1 #278

Open
logankarsten opened this issue Apr 4, 2019 · 0 comments
Open

Comments

@logankarsten
Copy link
Contributor

A Prior bug was logged to indicate the model crashes when the input dimensions on the forcing files is inconsistent with the geogrid file. That issue results in an ugly model crash with FORC_TYP=6. However, when FORC_TYP=1, the model does NOT crash and completes without error, even if the input forcing files are the incorrect dimension sizes. Currently unknown if this occurs with forcing files larger or smaller than the basin being ran.

Expected Behavior

The model should gracefully crash when the input LDASIN forcing files are of the incorrect dimension size.

Provide a check when the LDASIN files are read in to check for correct dimension sizes.

Current Behavior

The model does not error out or crash. It completes.

See above.

Possible Solution

Provide a check when forcing files are read in to ensure the dimension sizes match that of the geogrid file.

Steps to Reproduce (for bugs)

Your Environment

  • Version of the code used:
  • Operating System and version:
  • Compiler and version:
  • Other relevant information:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant