Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs reported by NRL #955

Closed
grantfirl opened this issue Aug 24, 2022 · 1 comment
Closed

Bugs reported by NRL #955

grantfirl opened this issue Aug 24, 2022 · 1 comment
Labels
bug

Comments

@grantfirl
Copy link
Collaborator

Description

  • The he variable in the cup_env subroutine in cu_gf_deep.F90 should be intent inout
  • line 125 in h20phys.f needs to check for division by 0
  • line 890 in radiation_astronomy.f should check for coszen /= 0
  • line 909 in sflx.f should always check for etp /= 0, not just for single-precision
  • line 1346 should check for cdf2 > 0
  • LUNs should not be in the range 100-102 for the Cray CCE compiler in iounitdef.f
  • the rho and orho variables are not being calculated for lextop=T in GFS_rrtmg_pre.F90
  • GFS_rad_time_vary.scm/fv3.F90 should be able to handle host-provided random number seeds rather than creating them locally
  • deep overshooting in samfdeepcnv.f can result in negative qv
@grantfirl grantfirl added the bug label Aug 24, 2022
This was referenced Aug 24, 2022
Merged
Merged
Merged
@dustinswales
Copy link
Collaborator

@grantfirl Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dustinswales @grantfirl