Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exponentiation instead of multiplication caused bad 2m temperatures #941

Closed
SamuelTrahanNOAA opened this issue Jun 10, 2022 · 0 comments
Closed

exponentiation instead of multiplication caused bad 2m temperatures #941

SamuelTrahanNOAA opened this issue Jun 10, 2022 · 0 comments
Labels
bug

Comments

@SamuelTrahanNOAA
Copy link
Collaborator

Description

A catastrophic typo in the mynn surface layer scheme produces bad 2m temperatures. This was reported and fixed by @joeolson42 in the NOAA-GSL fork. The NCAR main bugfix is in #940

 TH1D(I)=T1D(I)**(100000./P1D(I))**ROVCP !(Theta, K)

The first ** should be a *

 TH1D(I)=T1D(I)*(100000./P1D(I))**ROVCP !(Theta, K)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Read module_sf_mynn
  2. Sadness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamuelTrahanNOAA