Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlightjs dependency removed from ngx-highlight.js? #283

Closed
rajeshtarte opened this issue May 12, 2024 · 3 comments · Fixed by #287
Closed

highlightjs dependency removed from ngx-highlight.js? #283

rajeshtarte opened this issue May 12, 2024 · 3 comments · Fixed by #287
Assignees
@MurhafSousli

Comments

@rajeshtarte
Copy link

Removed dependency from ngx-hjightjs?

"dependencies": {
"highlight.js": "^11.5.1",
"highlightjs-line-numbers.js": "^2.8.0",
"tslib": "^2.0.0"
},

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] question

OS and Version?

Versions

Repro steps

The log given by the failure

Desired functionality

Mention any other details that might be useful
@MurhafSousli
Copy link
Owner

No it was not removed! what is your issue?

@rajeshtarte
Copy link
Author

rajeshtarte commented May 13, 2024 via email

@Jonesmann1337
Copy link

Jonesmann1337 commented May 28, 2024 •
edited

No it was not removed! what is your issue?

Actually it really was removed and I highly recommend to add it back to the project's package.json, otherwise we have to manually install this dependency on our own, which doesn't make much sense IMHO.

See diff

MurhafSousli added a commit that referenced this issue May 29, 2024
@MurhafSousli
fix: highlight.js dependency was removed in v11, closes #283
fd1a3f5
@MurhafSousli MurhafSousli linked a pull request May 29, 2024 that will close this issue
fix: highlight.js dependency was removed in v11 #287
Merged
@MurhafSousli MurhafSousli reopened this May 29, 2024
@MurhafSousli MurhafSousli self-assigned this May 29, 2024
MurhafSousli added a commit that referenced this issue May 29, 2024
@MurhafSousli
fix: highlight.js dependency was removed in v11, closes #283
4d995d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MurhafSousli MurhafSousli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: highlight.js dependency was removed in v11 MurhafSousli/ngx-highlightjs
3 participants
@MurhafSousli @rajeshtarte @Jonesmann1337