Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No UI error on headless server on player death #5251

Open
jdrueckert opened this issue Jun 9, 2024 · 0 comments
Open

No UI error on headless server on player death #5251

jdrueckert opened this issue Jun 9, 2024 · 0 comments
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Status: Needs Investigation Requires to be debugged or checked for feasibility, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems

Comments

@jdrueckert
Copy link
Member

What happened

I died in-game and the server logged an error.

How to reproduce

  1. Run a headless server
  2. Join the server
  3. Die
  4. Check the server logs and see the following error logged:
    18:28:18.165 [main] ERROR o.t.e.network.internal.NetClient - Error processing event
    java.lang.NullPointerException: Cannot invoke "org.terasology.engine.rendering.nui.NUIManager.getHUD()" because "this.nuiManager" is null
        at org.terasology.module.inventory.systems.CharacterInventorySystem.resetDropMark(CharacterInventorySystem.java:212)
        at org.terasology.module.inventory.systems.CharacterInventorySystem.onPlayerDeath(CharacterInventorySystem.java:241)
    

Proposed Fix

A headless server shouldn't try to run the respective code path in the first place as it is not expected to have a UI.
If the respective code is relevant for players, this should be run client-side.

@jdrueckert jdrueckert added Type: Bug Issues reporting and PRs fixing problems Status: Needs Investigation Requires to be debugged or checked for feasibility, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Size: S Small effort likely only affecting a single area and requiring little to no research labels Jun 9, 2024
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 4 milestone Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Status: Needs Investigation Requires to be debugged or checked for feasibility, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
Status: No status
Status: No status
Development

No branches or pull requests

1 participant