Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted unused viewsets #252

Merged
merged 2 commits into from
Jul 4, 2024
Merged

deleted unused viewsets #252

merged 2 commits into from
Jul 4, 2024

Conversation

purple-void
Copy link
Collaborator

@purple-void purple-void commented Jul 4, 2024

We're not using RegisterViewSet, UserLoginViewSet, and LogoutViewSet. djoser does of all of those for us, so we deleted them.

@seporterfield wants to keep ActivateUser for testing, but we don't understand why we would keep that code if we only want to test it. Though, we will keep it in for this PR.

we also renamed ActivateUser to ActivateUserViewSet for consistency.

@purple-void purple-void self-assigned this Jul 4, 2024
@purple-void purple-void linked an issue Jul 4, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebutify ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 7:41pm

@purple-void purple-void marked this pull request as ready for review July 4, 2024 19:39
@seporterfield seporterfield merged commit 8bc14b7 into main Jul 4, 2024
10 checks passed
@seporterfield seporterfield deleted the fix/251_unused_viewsets branch July 4, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unused viewsets
2 participants