changed incorrect ManyToMany fields #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: we renamed that branch to be accurate, so this is pull request is closed.
I changed incorrect ManyToMany fields to ForeignKey's (Django's way of ManyToOne).
This includes:
-posts, saved_posts, private_posts, upvotes, and downvotes in UserProfile
-upvotes and downvotes in Posts
Example:
Before, posts were labeled as ManyToMany, meaning that a UserProfile can have many posts (makes sense), but a post can have many UserProfiles (doesn't make sense).
This coincidentally helps with reducing the amount of tables we will use, although this doesn't solve the ManyToMany concern of creating tables.