Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psi4 _handle_output stops retries #407

Closed
jthorton opened this issue Jul 24, 2023 · 0 comments · Fixed by #409
Closed

Psi4 _handle_output stops retries #407

jthorton opened this issue Jul 24, 2023 · 0 comments · Fixed by #409

Comments

@jthorton
Copy link
Contributor

Describe the bug

Task retries are triggered only if the error raised from the compute call is a QCEngine RandomError. The Psi4 harness has a method to try and classify some failure modes, with general random failures with no error message given a new generic error message which does not contain the required keywords to trigger a retry. This is problematic in procedures like torsiondrives or optimizations as the entire calculation is stopped when in practice they normally work fine after retrying the single point calculation which has failed.

I think simply changing the error message to include the correct keyword (segmentation fault) would fix this.

To Reproduce

Seems to happen when running a pool of workers executing psi4 single points on the same computer, see attached qcschema temp file which just ends suddenly when computing the gradient.

qcschema.txt

Expected behavior

A psi4 task which fails with no error message should be restarted.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant