-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle_output_metadata deletes .extras values if they were returned on a FailedOperation object #397
Comments
I agree it shouldn't be dropping fields. I'm not able to reproduct the problem, though. The test below has extras on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If the
output_data
passed toutil.handle_output_metadata
is aFailedOperation
object (or corresponding dictionary) the reinstantiation of theFailedOperation
object on lines 208-212 removes these values.To Reproduce
Pass any
FailedOperation
object containing values in the.extras
field tohandle_output_metadata
and note that the returned object has these values removed.Expected behavior
All data on
output_data
fed tohandle_output_metadata
is included on the returned object, including.extras.
Additional context
The
TeraChemPBSHarness
andTeraChemFrontendHarness
both returnAtomicResult
orFailedOperation
objects upon success/failure of a calculation. When theFailedOperation
object is passed tohandle_ouput_metadata
the values in the.extras
field get.The text was updated successfully, but these errors were encountered: