-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release artifact tarballs are missing qcengine/_version.py replacement #337
Comments
Thanks for the report. I see some differences here https://github.com/MolSSI/QCElemental/blob/ff52f1460cdcd49f2255e507e5f389a4ffb247e5/setup.cfg#L35-L36 that I'll investigate Tuesday. |
ok, it was missing |
I very crudely patched in the commit ref in the Debian package[0], so personally I'm fine, but I think this might be worth making a release for, thanks for tracking it down and fixing it! [0] https://salsa.debian.org/debichem-team/qcengine/-/blob/master/debian/patches/fix_version.py |
Describe the bug
Psi4's FindPythonModule cmake module fails to find qcengine because it can't figure out the version:
The Cache has:
Same if I run
qcengine info
:This seems to be because the tarball if downloaded from Github still has (contrary to the QCElemental tarball, but I couldn't figure out why) the placeholders:
I also checked (randomly) the 0.13.0 tarball, and it's the same there.
QCElemental's tarball e.g. has:
To Reproduce
Expected behavior
Same as QCElemental
The text was updated successfully, but these errors were encountered: