Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache openmm_system upon creation in OpenMMHarness #191

Open
dotsdl opened this issue Dec 8, 2019 · 0 comments
Open

Cache openmm_system upon creation in OpenMMHarness #191

dotsdl opened this issue Dec 8, 2019 · 0 comments

Comments

@dotsdl
Copy link
Collaborator

dotsdl commented Dec 8, 2019

During #151, caching of the openmm_system was proposed as an optimization that could be valuable when we compute many gradients/energies for the same molecule in the same set of jobs. We currently cache the generated off_forcefield, so the same mechanism can be utilized for openmm_system.

The key/hash used for the cache must be selected with care. It must be insensitive to rotations or translations of the molecule, but should be sensitive to charge states, connectivity, and forcefield parameters. From @peastman:

One option for this is to serialize the System to XML with XmlSerializer.serialize(system) then compute a hash from the string. This will detect any change to the System or the Forces it contains, but will be unaffected by changes to particle positions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant