Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent dependency versions for pint and numpy #334

Closed
TyBalduf opened this issue Feb 29, 2024 · 1 comment
Closed

Inconsistent dependency versions for pint and numpy #334

TyBalduf opened this issue Feb 29, 2024 · 1 comment

Comments

@TyBalduf
Copy link
Contributor

Describe the bug
pyproject.toml has the following version specifications.

numpy = [
    { version = ">=1.12.0", python = "3.8" },
    { version = ">=1.26.1", python = ">=3.9,<3.13" },
]
python = "^3.7"
pint = ">=0.10.0"

On Python3.11, the default pip installation of qcelemental currently leads to numpy 1.26.4 and I had pint 0.11 installed. Any version of pint prior to 0.21 is incompatible with numpy >1.25 because the alen function was removed from numpy.

To Reproduce

  1. pip install qcelemental
  2. Run anything that requires importing pint.

python -c "import qcelemental as qcel; print(qcel.__file__, qcel.__version__)" --> /my_dir/lib/python3.11/site-packages/qcelemental/init.py 0.27.1

Desired behavior
The pint installation should have split versioning similar to the numpy dependency. I think this would look like

numpy = [
    { version = ">=1.12.0", python = "3.8" },
    { version = ">=1.26.1", python = ">=3.9,<3.13" },
]
python = "^3.7"
pint =[
    { version = ">=0.10", python = "3.8" },
    { version = ">=0.21", python = ">=3.9,<3.13" },
]
@loriab
Copy link
Collaborator

loriab commented Feb 29, 2024

Thanks for the report and the fix!

closed by #335

@loriab loriab closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants