Make sure extras is initialized as dict for Molecule #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loriab
reviewed
May 1, 2023
There was a problem hiding this comment.
Thanks. I'd ordinarily have put the empty dict here https://github.com/MolSSI/QCElemental/blob/master/qcelemental/models/molecule.py#L293 instead of the init. According to https://stackoverflow.com/a/73621352 , it's handled correctly.
But as-is should be fine.
loriab
approved these changes
May 1, 2023
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #303
Changelog description
Ensure extras attribute in Molecule is initialized as dict
Status