Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow only enabled for master branch? #258

Closed
awvwgk opened this issue Mar 12, 2021 · 2 comments · Fixed by #259
Closed

CI workflow only enabled for master branch? #258

awvwgk opened this issue Mar 12, 2021 · 2 comments · Fixed by #259

Comments

@awvwgk
Copy link
Contributor

awvwgk commented Mar 12, 2021

Is your feature request related to a problem? Please describe.

CI workflows are currently limited to the master branch. Is there any particular reason to not run tests on feature branches?

Describe the solution you'd like

Enable CI workflow for all branches to enable (easy) testing in forks.

@loriab
Copy link
Collaborator

loriab commented Mar 12, 2021

I had thought that master/master was triggering on push-to-master and push-to-fork-with-open-PR-to-master, but if you're seeing otherwise, I can revert. This was a recent change, sorry about that. I had been trying to suppress double testing on branches on upstream.

@awvwgk
Copy link
Contributor Author

awvwgk commented Mar 12, 2021

There may still be a push build, but on the fork, but those are usually opt-in. (Visible) double runs on push and pull_request would only happen for a branch in the repository with a PR against another branch in the same repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants