Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests #178

Closed
dgasmith opened this issue Dec 12, 2019 · 4 comments · Fixed by #211
Closed

Flaky tests #178

dgasmith opened this issue Dec 12, 2019 · 4 comments · Fixed by #211
Labels
Bug Code execution error

Comments

@dgasmith
Copy link
Collaborator

Describe the bug
Pubchem tests occasionally fail on CI.

Expected behavior
Pubchem tests should always pass to ensure CI is stable.

Additional context

We could consider a pytest wrapper like the following:

@pytest.mark.flaky(reruns=5)
def test_example():
    import random
    assert random.choice([True, False])

From this pytest module. Not an overwhelming fan of adding a new test depends, but could help. Also we could make with an xfail, but I feel this is dangerous.

@dgasmith dgasmith added the Bug Code execution error label Dec 12, 2019
@loriab
Copy link
Collaborator

loriab commented Dec 12, 2019

When pubchem gets busy, it tends to be for a spell longer than the qcel tests, so rerun in quick succession may not help.

@dgasmith
Copy link
Collaborator Author

@mattwelborn Maybe time for mock...?

@loriab
Copy link
Collaborator

loriab commented Dec 13, 2019

Before anyone spends more real time on that unfortunate file, may also want to consider pubchempy.

@dgasmith
Copy link
Collaborator Author

I would be up for copying pubchempys single file include with the license as the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Code execution error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants