Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov report combining #175

Closed
dgasmith opened this issue Dec 8, 2019 · 3 comments
Closed

Codecov report combining #175

dgasmith opened this issue Dec 8, 2019 · 3 comments
Labels
Question Further information is requested Testing Testing bug or enhancement

Comments

@dgasmith
Copy link
Collaborator

dgasmith commented Dec 8, 2019

At the moment, Codecov reports are not correctly merging resulting in a lower coverage status than is truly available. Unsure why this is as all reports are uploaded correctly, it looks like only the first report is correctly merged.

A small hunch is that the git SHA is not correctly being uploaded from all reports.

@dgasmith dgasmith added Question Further information is requested Testing Testing bug or enhancement labels Dec 8, 2019
@loriab
Copy link
Collaborator

loriab commented Dec 8, 2019

looks like a GH actions consequence. weren't you seeing a problem with GHA and SHAs in another repo? or was that azure?

@dgasmith
Copy link
Collaborator Author

dgasmith commented Dec 8, 2019

Yes, absolutely a GHA consequence. Travis is a "trusted" CI provider for Codecov so it automatically takes care of a number of issues.

From Codecov FAQ:

The upload token is required for all uploads, except originating from public project using Travis-CI, Circle CI, or AppVeyor CI.

See a PR that could fix this here. From this I derive that we may need to (potentially) upload additional data, but isn't commented on here.

@loriab
Copy link
Collaborator

loriab commented Jan 7, 2020

After #180, codecov has returned to pre-GHA levels, so I think this is resolved. Please reopen if more services communications trouble suspected.

@loriab loriab closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Further information is requested Testing Testing bug or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants