Allow user identifiers to be set directly against the client #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives an 'escape hatch' for people who don't want `setcookie` or who aren't necessarily in a web context when php_sapi_name() != 'cli'.
|
I think this change makes sense. Would you be interested in reviving it? I can probably merge by hand and fix the conflicts otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives an 'escape hatch' for people who, for whatever reason, want to manage the persistence/lifecycle of the user information themselves.
For example, you might like to use your framework's version of
request.cookiesto obtain the information. Or you might not need cookies emitted because you already have persistent user profiles accessible through your framework's user/authentication system.Fixes #75