-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto_route fragment support #1980
Comments
It really doesn't look like it does support fragments... |
@TekExplorer are you you saying you can't read #fragment from a url? |
I'm saying I can't use it as a parameter In my route. This is important to me as the fragment is sometimes required, or otherwise has important semantic meaning. Go router builder has the same issue if just not addressing the fragment at all, despite being otherwise trivial to implement. |
@Milad-Akarie What are your thoughts on the matter? Do you intend to properly support fragments for routes? |
@TekExplorer fragment support is added in the latest version of auto_route, make sure you update the generator as well. use the @urlFragment annotation the same way you'd use @QueryParam. |
I want to have certain routes use fragments to represent the current location, such as the current file being edited
I also use it for filters in some places, though I recognize that those could be query parameters.
Its also used for my login route, where a url needs to be inputted and then an api key on the next page. That Uri needs to be in the path, but urlEncoding it looks honestly terrible. Plus, its not a great api for the sake of deep links.
I dont really see fragments used at all, so i'm a little concerned.
If its not supported, what would it take to support it?
The text was updated successfully, but these errors were encountered: