Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set multiple default service URLs. #99

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Conversation

Eskibear
Copy link
Member

This PR enables the feature to set multiple service URL in settings.

  1. Type of the config is changed to string or array of strings
  • if string, fallback to previous behavior.
  • if array, it first require users to pick on from the list.
  1. About the code changes, as different services has different results, now I added a new class ServiceManager to handle stuffs like getting available versions, starters, etc.

@Eskibear Eskibear requested a review from jdneo January 14, 2019 06:58
@Eskibear Eskibear added this to the 0.5.0 milestone Jan 14, 2019
package.json Outdated Show resolved Hide resolved
@Eskibear
Copy link
Member Author

in 3204e52 :

a string: use the string as service url directly
an empty array : fallback to use the official service
an array with single element: use the element as service url directly
an array with 2+ elements: let users select one.

@Eskibear Eskibear merged commit aee00bc into master Jan 14, 2019
@Eskibear Eskibear deleted the multi-service-url branch January 14, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants