Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require few member accessor api from mbedtls_ssl_session and mbedtls_ssl_context structure #8456

Closed
sabarike opened this issue Oct 31, 2023 · 3 comments
Labels
component-tls enhancement needs-info An issue or PR which needs further info from the reporter / author priority-high High priority - will be reviewed soon size-m Estimated task size: medium (~1w)

Comments

@sabarike
Copy link

sabarike commented Oct 31, 2023

We are integrating the latest MbedTLS v3.5.0 from MbedTLS v2.x. In our code, we are accessing the below private structure members. As per the 3.0-migration-guide.md, we have to use the setter/getter api for access. But there is no setter/getter apis for below members.

Members from mbedtls_ssl_session structure

  • ciphersuite
  • master
  • id_len
  • id

Members from mbedtls_ssl_context structure

  • handshake
  • state
  • in_window_top
  • in_window
  • cur_out_ctr
  • session_negotiate

Could you help us to find if there is setter/getter apis for above member access? If no setter/getter api, could you add those accessor apis ?

@tom-cosgrove-arm tom-cosgrove-arm added enhancement size-m Estimated task size: medium (~1w) priority-high High priority - will be reviewed soon component-tls labels Oct 31, 2023
@minosgalanakis minosgalanakis added this to Mbed TLS PRIVATE ( 3.6 Release Dep) in EPICs for Mbed TLS Nov 2, 2023
@minosgalanakis
Copy link
Contributor

We are currently reviewing/considering adding acessors for specific MBEDTLS_PRIVATE structures.

Could you please provide more information on your use-cases for the following mbedtls_ssl_context members:

  • in_window_top
  • in_window
  • cur_out_ctr
  • session_negotiate

As well as the mbedtls_ssl_session->master?

Please check #8529 for the overall plan, and feel free to comment there as well.

@minosgalanakis minosgalanakis added the needs-info An issue or PR which needs further info from the reporter / author label Nov 27, 2023
@tom-cosgrove-arm
Copy link
Contributor

Ping @sabarike - could you provide more information as above please?

@minosgalanakis
Copy link
Contributor

As discussed in issue 4383 and the design review issue 8529, accessors for the id and ciphersuite_id and id_len are being added in pr8888

The handshake and handshake state are not to be directly exposed, but approporiate callbacks have been added in other tickets.

I will be closing this ticket, but please feel free to reach out with your use requirements for the other accessors listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-tls enhancement needs-info An issue or PR which needs further info from the reporter / author priority-high High priority - will be reviewed soon size-m Estimated task size: medium (~1w)
Projects
Status: [3.6] Mbed TLS PRIVATE
Development

No branches or pull requests

3 participants