Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS 1.3: Rename mbedtls_ssl_tls13_conf_early_data() #6909

Closed
ronald-cron-arm opened this issue Jan 11, 2023 · 0 comments · Fixed by #8487
Closed

TLS 1.3: Rename mbedtls_ssl_tls13_conf_early_data() #6909

ronald-cron-arm opened this issue Jan 11, 2023 · 0 comments · Fixed by #8487
Assignees
@yanrayw
Labels
component-tls13 enhancement size-s Estimated task size: small (~2d)

Comments

@ronald-cron-arm
Copy link
Contributor

ronald-cron-arm commented Jan 11, 2023 •
edited
Loading

Suggested enhancement

The public API function mbedtls_ssl_tls13_conf_early_data() should be renamed to mbedtls_ssl_conf_tls13_early_data() or even
mbedtls_ssl_conf_early_data() as in the future this may not be specific to TLS 1.3.

The early data support is experimental thus backward compatibility is not an issue for this renaming.

Justification

Consistency. Only function related to configuration and specific to TLS 1.3 with that prefix. We've rather been using the prefix mbedtls_ssl_conf_tls13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanrayw yanrayw

Labels
component-tls13 enhancement size-s Estimated task size: small (~2d)
Projects
Past EPICs
Status: [3.6] TLS 1.3 early data
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TLS 1.3: Rename early_data and max_early_data_size configuration function yanrayw/mbedtls
2 participants
@ronald-cron-arm @yanrayw