Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the the private field acces of mbedtls_dhm_context with APIs #5015

Closed
gabor-mezei-arm opened this issue Oct 5, 2021 · 0 comments · Fixed by #8702
Closed

Replace the the private field acces of mbedtls_dhm_context with APIs #5015

gabor-mezei-arm opened this issue Oct 5, 2021 · 0 comments · Fixed by #8702
Assignees
@minosgalanakis
Labels
enhancement size-s Estimated task size: small (~2d)

Comments

@gabor-mezei-arm
Copy link
Contributor

gabor-mezei-arm commented Oct 5, 2021 •
edited by daverodgman
Loading

As part of #4683, the review of programs for MBEDTLS_PRIVATE field usage concluded that are usage of private fields of mbedtls_dhm_context structure. All occurrence of this usage can be avoided by using APIs.

As part of this issue all occurrence of the 'mbedtls_dhm_context' private filed usage must be replaced with the following APIs:

field replacing getter APIs replacing setter APIs
len mbedtls_dhm_get_len
P, G mbedtls_dhm_get_value mbedtls_dhm_set_group

These are the affected files:

  • pkey/dh_server.c
  • benchmark.c
@gabor-mezei-arm gabor-mezei-arm mentioned this issue Oct 5, 2021
Closed
9 tasks
@gabor-mezei-arm gabor-mezei-arm added the size-s Estimated task size: small (~2d) label Oct 26, 2021
@daverodgman daverodgman moved this from Mbed TLS early 3.x to High priority 3.0 follow-up in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/1 Jan 10, 2022
@daverodgman daverodgman moved this from High priority 3.0 follow-up to Mbed TLS early 3.x in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/1 Jan 10, 2022
@daverodgman daverodgman added this to Mbed TLS 3.x in EPICs for Mbed TLS Mar 30, 2022
@daverodgman daverodgman added this to Mbed TLS 3.x in Backlog for Mbed TLS Feb 22, 2023
@daverodgman daverodgman removed this from Mbed TLS 3.x in EPICs for Mbed TLS Feb 22, 2023
@minosgalanakis minosgalanakis added this to Mbed TLS PRIVATE ( 3.6 Release Dep) in EPICs for Mbed TLS Nov 13, 2023
@minosgalanakis minosgalanakis removed this from Mbed TLS 3.x in Backlog for Mbed TLS Nov 13, 2023
@minosgalanakis minosgalanakis mentioned this issue Nov 21, 2023
Closed
@minosgalanakis minosgalanakis self-assigned this Jan 12, 2024
@minosgalanakis minosgalanakis mentioned this issue Jan 15, 2024
Merged
3 tasks
@mpg mpg closed this as completed in #8702 Feb 10, 2024
@minosgalanakis minosgalanakis removed this from [3.6] Mbed TLS PRIVATE in EPICs for Mbed TLS Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minosgalanakis minosgalanakis

Labels
enhancement size-s Estimated task size: small (~2d)
Projects
Past EPICs
Status: [3.6] Mbed TLS PRIVATE
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MBEDTLS_PRIVATE] Update dhm context in programs minosgalanakis/mbedtls
4 participants
@daverodgman @minosgalanakis @bensze01 @gabor-mezei-arm