{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":714380633,"defaultBranch":"main","name":"nushell","ownerLogin":"MarikaChlebowska","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-11-04T18:28:54.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/27893578?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1701031733.0","currentOid":""},"activityList":{"items":[{"before":"ef46eb7a353a0a1ed207720c2959e065ffdc54e7","after":"2171aee5c56252189f71b5e876e80746d23ceb10","ref":"refs/heads/quote-external-command-arguments","pushedAt":"2023-12-04T18:10:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"fix glob expansion","shortMessageHtmlLink":"fix glob expansion"}},{"before":"40ca7aaaaa38a0bb34e7c427dd22681e944ccef6","after":"ef46eb7a353a0a1ed207720c2959e065ffdc54e7","ref":"refs/heads/quote-external-command-arguments","pushedAt":"2023-12-04T12:33:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"remove previous fix and fix trim_expand_and_apply_arg trimming when it shouldn't","shortMessageHtmlLink":"remove previous fix and fix trim_expand_and_apply_arg trimming when i…"}},{"before":"41aed647ccffedb03e04baf757014033f8bbb811","after":"40ca7aaaaa38a0bb34e7c427dd22681e944ccef6","ref":"refs/heads/quote-external-command-arguments","pushedAt":"2023-12-03T17:23:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"fix to parse to string only when needed","shortMessageHtmlLink":"fix to parse to string only when needed"}},{"before":"329856bece9b41279fad5b42a70af0127f038d35","after":"41aed647ccffedb03e04baf757014033f8bbb811","ref":"refs/heads/quote-external-command-arguments","pushedAt":"2023-12-03T14:45:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"quote string dollar expression before passing to external calls","shortMessageHtmlLink":"quote string dollar expression before passing to external calls"}},{"before":"1ff8c2d81dea68e90a6a61b68a50a2098b1d6a8a","after":"b227eea6682ede22bccec71c552156775440d424","ref":"refs/heads/main","pushedAt":"2023-12-03T14:17:28.000Z","pushType":"push","commitsCount":27,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"Add checks for ports (#11214)\n\n# Description\r\nThis PR adds checks for ports. This fixes unexpected output similar to\r\nthe one in the comment\r\nhttps://github.com/nushell/nushell/pull/11210#issuecomment-1837152357.\r\n\r\n* before\r\n\r\n```console\r\n/data/source/nushell> port 65536 99999                                                                                        \r\n41233\r\n```\r\n\r\n* after\r\n\r\n```console\r\n/data/source/nushell> port 65536 99999                                                                                             \r\nError: nu::shell::cant_convert\r\n\r\n  × Can't convert to u16.\r\n   ╭─[entry #1:1:1]\r\n 1 │ port 65536 99999\r\n   ·      ──┬──\r\n   ·        ╰── can't convert usize to u16\r\n   ╰────\r\n  help: out of range integral type conversion attempted (min: 0, max: 65535)\r\n```\r\n\r\n# User-Facing Changes\r\nN/A\r\n\r\n# Tests + Formatting\r\n* [x] add `port_out_of_range` test\r\n\r\n# After Submitting\r\nN/A","shortMessageHtmlLink":"Add checks for ports (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2022490689\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/11214\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/11214/hovercard\" href=\"https://github.com/nushell/nushell/pull/11214\">nushell#11214</a>)"}},{"before":"867c9701759f89976e2ff954744a77b7b0654a1e","after":"f4bb295bef77561ee545d5e0b1c5a80cdca2b9a9","ref":"refs/heads/add-metadata-to-filters","pushedAt":"2023-11-27T17:58:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"change .set_metadata to .into_pipeline_data_with_metadata","shortMessageHtmlLink":"change .set_metadata to .into_pipeline_data_with_metadata"}},{"before":null,"after":"867c9701759f89976e2ff954744a77b7b0654a1e","ref":"refs/heads/add-metadata-to-filters","pushedAt":"2023-11-26T20:48:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"add metadata to some filters","shortMessageHtmlLink":"add metadata to some filters"}},{"before":"494a5a5286db91381453d08ebcf9f8cb3babdc35","after":"1ff8c2d81dea68e90a6a61b68a50a2098b1d6a8a","ref":"refs/heads/main","pushedAt":"2023-11-26T20:28:24.000Z","pushType":"push","commitsCount":32,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"Cp target expansion (#11152)\n\n# Description\r\nThis PR addresses issue with cp brough up on\r\n[discord](https://discord.com/channels/601130461678272522/614593951969574961/1177669443917189130)\r\nwhere target of cp is not correctly expanded.\r\nIf one has directory `test` with file `file.txt` in it then the\r\nfollowing command (in one line or inside a `do` block):\r\n```nu\r\ncd test; let file = 'copy.txt'; cp file.txt $file\r\n```\r\nwill create a `copy.txt` in `.` not in `test` instead. This happens\r\nbecause target of `cp` is a variable which is not expanded unlike a\r\nstring literal\r\n\r\n# User-Facing Changes\r\n`cp` will correctly parse realative target paths\r\n\r\n# Tests + Formatting\r\n<!--\r\nDon't forget to add tests that cover your changes.\r\n\r\nMake sure you've run and fixed any issues with these commands:\r\n\r\n- `cargo fmt --all -- --check` to check standard code formatting (`cargo\r\nfmt --all` applies these changes)\r\n- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to\r\ncheck that you're using the standard code style\r\n- `cargo test --workspace` to check that all tests pass (on Windows make\r\nsure to [enable developer\r\nmode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))\r\n- `cargo run -- -c \"use std testing; testing run-tests --path\r\ncrates/nu-std\"` to run the tests for the standard library\r\n\r\n> **Note**\r\n> from `nushell` you can also use the `toolkit` as follows\r\n> ```bash\r\n> use toolkit.nu # or use an `env_change` hook to activate it\r\nautomatically\r\n> toolkit check pr\r\n> ```\r\n-->\r\n\r\n# After Submitting\r\n<!-- If your PR had any user-facing changes, update [the\r\ndocumentation](https://github.com/nushell/nushell.github.io) after the\r\nPR is merged, if necessary. This will help us keep the docs up to date.\r\n-->","shortMessageHtmlLink":"Cp target expansion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2010150020\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/11152\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/11152/hovercard\" href=\"https://github.com/nushell/nushell/pull/11152\">nushell#11152</a>)"}},{"before":null,"after":"329856bece9b41279fad5b42a70af0127f038d35","ref":"refs/heads/quote-external-command-arguments","pushedAt":"2023-11-19T12:46:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"quote string dollar expression before passing to external calls","shortMessageHtmlLink":"quote string dollar expression before passing to external calls"}},{"before":"77fbf3e2d24b49bf964c41532e6a516f5347b554","after":"494a5a5286db91381453d08ebcf9f8cb3babdc35","ref":"refs/heads/main","pushedAt":"2023-11-19T12:31:32.000Z","pushType":"push","commitsCount":67,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"Add `mktemp` command (#11005)\n\ncloses #10845 \r\n\r\nI've opened this a little prematurely to get some questions answered\r\nbefore I cleanup the code.\r\n\r\nAs I started trying to better understand GNUs `mktemp` I've realized its\r\nkind of peculiar and we might want to change its behavior to introduce\r\nit to nushell.\r\n\r\n#### quiet and dry run\r\n\r\nDoes it make sense to keep the `quiet` and `dry_run` flags? I don't\r\nthink so. The GNU documentation says this about the dry run flag \"Using\r\nthe output of this command to create a new file is inherently unsafe, as\r\nthere is a window of time between generating the name and using it where\r\nanother process can create an object by the same name.\" So yeah why keep\r\nit? As far as quiet goes, does it make sense to silence the errors in\r\nnushell?\r\n\r\n#### other confusing flags\r\n\r\nAccording to the [gnu\r\ndocs](https://www.gnu.org/software/coreutils/manual/html_node/mktemp-invocation.html),\r\nthe `-t` flag is deprecated and the `-p`/ `--tempdir` are the same flag\r\nwith the only difference being `--tempdir` takes an optional path, Given\r\nthat, I've broken the `-p` away from `--tempdir`. Now there is one\r\nswitch `--tmpdir`/`-t` and one named param `--tmpdir-path`/`-p`.\r\n\r\nGNU mktemp\r\n```\r\n  -p DIR, --tmpdir[=DIR]  interpret TEMPLATE relative to DIR; if DIR is not\r\n                        specified, use $TMPDIR if set, else /tmp.  With\r\n                        this option, TEMPLATE must not be an absolute name;\r\n                        unlike with -t, TEMPLATE may contain slashes, but\r\n                        mktemp creates only the final component\r\n  -t                  interpret TEMPLATE as a single file name component,\r\n                        relative to a directory: $TMPDIR, if set; else the\r\n                        directory specified via -p; else /tmp [deprecated]\r\n\r\n```\r\nto\r\nnushell mktemp\r\n```\r\n  -p, --tmpdir-path <Filepath> # named param, must provide a path\r\n  -t, --tmpdir                 # a switch\r\n```\r\n\r\nIs this a terrible idea?\r\n\r\nWhat should I do?\r\n\r\n---------\r\n\r\nCo-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>","shortMessageHtmlLink":"Add <code>mktemp</code> command (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1984589788\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/11005\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/11005/hovercard\" href=\"https://github.com/nushell/nushell/pull/11005\">nushell#11005</a>)"}},{"before":"8d282aa7e931c8ab446ab270f840f63945608e2a","after":"41359d4eaa9d267030d3cef1bb01dbf4083b6809","ref":"refs/heads/fix-deparsing-wth-brackets","pushedAt":"2023-11-13T16:30:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"quote only with spcial characters","shortMessageHtmlLink":"quote only with spcial characters"}},{"before":"692788356121b7190037e1a53d4bea212279ef93","after":"8d282aa7e931c8ab446ab270f840f63945608e2a","ref":"refs/heads/fix-deparsing-wth-brackets","pushedAt":"2023-11-12T18:03:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"allow alphanumeric without quotes, fix typo","shortMessageHtmlLink":"allow alphanumeric without quotes, fix typo"}},{"before":"6bf02a66835fce31e8f4fe28f94ecea8b9b96c59","after":"692788356121b7190037e1a53d4bea212279ef93","ref":"refs/heads/fix-deparsing-wth-brackets","pushedAt":"2023-11-12T14:39:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"also handle string containing special characters","shortMessageHtmlLink":"also handle string containing special characters"}},{"before":"77fbf3e2d24b49bf964c41532e6a516f5347b554","after":"6bf02a66835fce31e8f4fe28f94ecea8b9b96c59","ref":"refs/heads/fix-deparsing-wth-brackets","pushedAt":"2023-11-11T15:47:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"fix parsing of strings with brackets as script arguments","shortMessageHtmlLink":"fix parsing of strings with brackets as script arguments"}},{"before":null,"after":"77fbf3e2d24b49bf964c41532e6a516f5347b554","ref":"refs/heads/fix-deparsing-wth-brackets","pushedAt":"2023-11-11T15:46:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"better help message for MissingPositional error (#10949)\n\nAdded \"Use `--help` for more information.\" to the help of\r\nMissingPositional error\r\n- this PR should close\r\n[#10946](https://github.com/nushell/nushell/issues/10946)\r\n\r\n**Before:**\r\n\r\n![image](https://github.com/nushell/nushell/assets/1835944/629aeaae-e985-41aa-a791-05ef062e988e)\r\n\r\n**After:**\r\n\r\n![image](https://github.com/nushell/nushell/assets/1835944/0bc1868c-ffed-4440-ad98-2cf29aa8c656)\r\n\r\n\r\n\r\n<!--\r\nif this PR closes one or more issues, you can automatically link the PR\r\nwith\r\nthem by using one of the [*linking\r\nkeywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),\r\ne.g.\r\n- this PR should close #xxxx\r\n- fixes #xxxx\r\n\r\nyou can also mention related issues, PRs or discussions!\r\n-->\r\n\r\n# Description\r\n<!--\r\nThank you for improving Nushell. Please, check our [contributing\r\nguide](../CONTRIBUTING.md) and talk to the core team before making major\r\nchanges.\r\n\r\nDescription of your pull request goes here. **Provide examples and/or\r\nscreenshots** if your changes affect the user experience.\r\n-->\r\n\r\n# User-Facing Changes\r\n<!-- List of all changes that impact the user experience here. This\r\nhelps us keep track of breaking changes. -->\r\n\r\n# Tests + Formatting\r\n<!--\r\nDon't forget to add tests that cover your changes.\r\n\r\nMake sure you've run and fixed any issues with these commands:\r\n\r\n- `cargo fmt --all -- --check` to check standard code formatting (`cargo\r\nfmt --all` applies these changes)\r\n- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to\r\ncheck that you're using the standard code style\r\n- `cargo test --workspace` to check that all tests pass (on Windows make\r\nsure to [enable developer\r\nmode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))\r\n- `cargo run -- -c \"use std testing; testing run-tests --path\r\ncrates/nu-std\"` to run the tests for the standard library\r\n\r\n> **Note**\r\n> from `nushell` you can also use the `toolkit` as follows\r\n> ```bash\r\n> use toolkit.nu # or use an `env_change` hook to activate it\r\nautomatically\r\n> toolkit check pr\r\n> ```\r\n-->\r\n\r\n# After Submitting\r\n<!-- If your PR had any user-facing changes, update [the\r\ndocumentation](https://github.com/nushell/nushell.github.io) after the\r\nPR is merged, if necessary. This will help us keep the docs up to date.\r\n-->\r\n\r\n---------\r\n\r\nCo-authored-by: Denis Zorya <denis.zorya@trafigura.com>","shortMessageHtmlLink":"better help message for MissingPositional error (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1977410837\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/10949\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/10949/hovercard\" href=\"https://github.com/nushell/nushell/pull/10949\">nushell#10949</a>)"}},{"before":"15e0ee80770d0314ee2d25896a2a26e9d912d20b","after":"a88d0c7addd10720be549f400df777654995c51c","ref":"refs/heads/csv_parsing_better_error","pushedAt":"2023-11-05T15:44:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"fix formatting","shortMessageHtmlLink":"fix formatting"}},{"before":null,"after":"15e0ee80770d0314ee2d25896a2a26e9d912d20b","ref":"refs/heads/csv_parsing_better_error","pushedAt":"2023-11-05T15:08:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"add more descriptive error message when passing list to from_csv","shortMessageHtmlLink":"add more descriptive error message when passing list to from_csv"}},{"before":null,"after":"bfb95862c149eeb8cd184d2c1a09cbefe31ab5e3","ref":"refs/heads/mchlebowska/10183-remove-themes-from-global","pushedAt":"2023-11-04T18:33:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"MarikaChlebowska","name":"Marika Chlebowska","path":"/MarikaChlebowska","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/27893578?s=80&v=4"},"commit":{"message":"Removed themes from global variables and moved them to #env instead","shortMessageHtmlLink":"Removed themes from global variables and moved them to #env instead"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADwM4w5QA","startCursor":null,"endCursor":null}},"title":"Activity · MarikaChlebowska/nushell"}